Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for Float32 #39

Closed
stevengj opened this issue Aug 12, 2022 · 2 comments
Closed

add tests for Float32 #39

stevengj opened this issue Aug 12, 2022 · 2 comments

Comments

@stevengj
Copy link
Member

stevengj commented Aug 12, 2022

Just wrap all tests in

for T in (Float32, Float64), n in (....)
   A = skewhermitian!(rand(T), n, n)
   ...
end

and maybe add some type assertions like eigvals(A)::Vector{Complex{T}} ≈ [....]

@stevengj
Copy link
Member Author

Thanks! In general, I would suggest closing issues from a PR (just put closes #39 in the description of the PR), or at least from commits (put closes #39 in the commit message) if you are pushing the commits directly.

@stevengj
Copy link
Member Author

Looking at https://github.com/smataigne/SkewLinearAlgebra.jl/blob/main/test/runtests.jl, I don't see any tests for Float32. Did you close this by accident?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants