type piracy

[stevengj]

These are type piracy and should be removed: https://github.com/smataigne/SkewLinearAlgebra.jl/blob/365b0a1a4c7f07235ba0bdca07b5da8fbe30ebb8/src/hessenberg.jl#L3-L7

Just call the low-level constructor directly.

[smataigne]

Fixed for Hessenberg, as HessenbergQ is called using Hessenberg(not called directly by my code), I don't see how to do it for HessenbergQ without extending the definition of the construstor.

[stevengj]

Can't you just call LA.HessenbergQ{eltype(F.factors),S,W,true}(F.uplo, F.factors, F.τ) directly?

[stevengj]

Or is the problem that this is called internally by LinearAlgebra?

[smataigne]

The constructor of HessenbergQ is called internally by LinearAlgebra when the constructor of Hessenberg is called

[stevengj]

Oh, in that case we should:

1. Stick with type piracy for now to extend the HessenbergQ constructor
2. Submit a patch to Julia to extend the HessenbergQ in LinearAlgebra (once that is merged we can remove our pirated constructor here using a VERSION check).

[stevengj]

Actually, now that you have SkewHermTridiagonal, you can just use that in your HessenbergQ constructor — that will no longer be type piracy since you "own" this type.

[smataigne]

Thanks! I will change that now