Infinite loop with NaNs

[simonbyrne]

Similar to https://github.com/JuliaLang/julia/issues/21757, the following causes an infinite loop:

using GenericSVD
X = [0.0 NaN; NaN Inf]
GenericSVD.generic_svdfact!(X)

[tlienart]

The Julia issue was closed by Viral but the problem seems to still be there for me on julia 0.6.3:

Julia Version 0.6.3
Commit d55cadc350 (2018-05-28 20:20 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, broadwell)

on Julia 7 it doesn't hang but spews an error which doesn't look right (?)

ERROR: MethodError: no method matching LinearAlgebra.Bidiagonal{Float64,V} where V<:AbstractArray{Float64,1}(::Array{Float64,1}, ::Array{Float64,1}, ::Bool)
Closest candidates are:
  LinearAlgebra.Bidiagonal{Float64,V} where V<:AbstractArray{Float64,1}(::V<:AbstractArray{T,1}, ::V<:AbstractArray{T,1}, ::AbstractChar) where {T, V<:AbstractArray{T,1}} at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/LinearAlgebra/src/bidiag.jl:9
  LinearAlgebra.Bidiagonal{Float64,V} where V<:AbstractArray{Float64,1}(::Any) where T<:AbstractArray at abstractarray.jl:22
Stacktrace:
 [1] bidiagonalize_tall!(::Array{Float64,2}) at /Users/tlienart/.julia/packages/GenericSVD/abus/src/bidiagonalize.jl:49
 [2] #generic_svdfact!#3(::Bool, ::Bool, ::Function, ::Array{Float64,2}) at /Users/tlienart/.julia/packages/GenericSVD/abus/src/GenericSVD.jl:20
 [3] generic_svdfact!(::Array{Float64,2}) at /Users/tlienart/.julia/packages/GenericSVD/abus/src/GenericSVD.jl:13
 [4] top-level scope

[simonbyrne]

Yes, the Julia issue was just tracking lapack. I need to figure out how that change should affect this code.