Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 512 NUM_THREADS for OpenBLAS #42584

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Use 512 NUM_THREADS for OpenBLAS #42584

merged 3 commits into from
Oct 12, 2021

Conversation

ViralBShah
Copy link
Member

@staticfloat
Copy link
Member

I think it’s worth mentioning in the comment where someone should look for the code that actually limits the number of threads.

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 11, 2021

I think it’s worth mentioning in the comment where someone should look for the code that actually limits the number of threads.

Within openblas? Within Julia we have removed that restriction at the moment. My thought is we can experiment a little bit to see how that feels before bringing the newly discussed limit back.

@ViralBShah ViralBShah added building Build system, or building Julia or its dependencies linear algebra Linear algebra labels Oct 11, 2021
@staticfloat
Copy link
Member

Within Julia we have removed that restriction at the moment.

I thought that we wanted to re-introduce a maximum of e.g. 32, unless an environment variable is set to override that default.

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 11, 2021

Within Julia we have removed that restriction at the moment.

I thought that we wanted to re-introduce a maximum of e.g. 32, unless an environment variable is set to override that default.

Yes, we discussed doing that. My thought was that since we are early enough in the 1.8 cycle, we can see how things feel for now with the large limits and get some regression testing in, and introduce the 32 max threads a little closer to release (or at least wait a few weeks).

Should we open an issue and put it on the milestone to make sure we don't forget?

@ViralBShah ViralBShah changed the title Use 4096 NUM_THREADS for OpenBLAS Use 512 NUM_THREADS for OpenBLAS Oct 12, 2021
@ViralBShah ViralBShah merged commit 5a14037 into master Oct 12, 2021
@ViralBShah ViralBShah deleted the vs/openblas-threads branch October 12, 2021 15:30
daviehh pushed a commit to daviehh/julia that referenced this pull request Nov 11, 2021
daviehh pushed a commit to daviehh/julia that referenced this pull request Nov 16, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants