Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source build of p7zip on FreeBSD #33431

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Fix source build of p7zip on FreeBSD #33431

merged 1 commit into from
Oct 1, 2019

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Sep 30, 2019

Adds a patch from the FreeBSD Ports Collection to fix #33430. I've applied the patch conditional on FreeBSD but it seems like it could be fine to apply to the others.

Marking for backport to 1.3 since the change that broke this was also marked for 1.3.

@ararslan ararslan added building Build system, or building Julia or its dependencies system:freebsd Affects only FreeBSD bugfix This change fixes an existing bug backport 1.3 labels Sep 30, 2019
@staticfloat
Copy link
Member

I would rather apply it unconditionally. Also, I love it when you assign an issue to me, and then go ahead and just fix it yourself. :)

@ararslan ararslan merged commit 4fa6a62 into master Oct 1, 2019
@ararslan ararslan deleted the aa/fix-fbsd-7z branch October 1, 2019 06:25
KristofferC pushed a commit that referenced this pull request Oct 3, 2019
@KristofferC KristofferC mentioned this pull request Oct 3, 2019
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies system:freebsd Affects only FreeBSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD can't build 7z with USE_BINARYBUILDER=0
3 participants