Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the optimizer's use of cached varargs type info for _apply unrolling #28079

Merged
merged 2 commits into from
Jul 15, 2018

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Jul 12, 2018

No description provided.

@jrevels jrevels force-pushed the jr/fixvarargsapply branch 2 times, most recently from 8872a9a to 25f7ad1 Compare July 12, 2018 14:56
jrevels added a commit that referenced this pull request Jul 12, 2018
@jrevels
Copy link
Member Author

jrevels commented Jul 12, 2018

Note that this closes #25492.

@jrevels
Copy link
Member Author

jrevels commented Jul 13, 2018

Test failures are unrelated. The CircleCI ones are kinda hilarious.

The single Travis failure was just to GitHub not being reachable for some reason.

The CircleCI tests ran after #28091 was merged, which seems to be what caused the failures there - looks like the JULIA_CPU_CORES deprecation message is getting printed while executing certain commands whose raw output is being tested against, and the tests don't account for the JULIA_CPU_CORES deprecation. cc @StefanKarpinski

I'll wait until this evening to merge to give more time for folks to review if they'd like to.

@StefanKarpinski
Copy link
Member

Where is the use of JULIA_CPU_CORES coming from?

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Jul 13, 2018

Oh, I see, CircleCI does this broken thing where it uses the configuration from the branch to test the result of merging the branch with master. So the configuration is wrong and sets JULIA_CPU_CORES instead of JULIA_CPU_THREADS. So a rebase on master should pass.

@jrevels jrevels force-pushed the jr/fixvarargsapply branch from 25f7ad1 to d292f2e Compare July 13, 2018 12:58
jrevels added a commit that referenced this pull request Jul 13, 2018
@StefanKarpinski
Copy link
Member

FreeBSD failure is the new OffsetArray issue which is unrelated. There's a conflict though, so you may as well rebase again after that gets fixed.

@jrevels jrevels force-pushed the jr/fixvarargsapply branch from d292f2e to 5040e53 Compare July 14, 2018 16:09
@jrevels
Copy link
Member Author

jrevels commented Jul 14, 2018

Rebased again, hopefully this'll be the one!

@Keno Keno merged commit c125102 into master Jul 15, 2018
@martinholters martinholters deleted the jr/fixvarargsapply branch July 15, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants