-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the optimizer's use of cached varargs type info for _apply unrolling #28079
Conversation
8872a9a
to
25f7ad1
Compare
Note that this closes #25492. |
Test failures are unrelated. The CircleCI ones are kinda hilarious. The single Travis failure was just to GitHub not being reachable for some reason. The CircleCI tests ran after #28091 was merged, which seems to be what caused the failures there - looks like the I'll wait until this evening to merge to give more time for folks to review if they'd like to. |
Where is the use of |
Oh, I see, CircleCI does this broken thing where it uses the configuration from the branch to test the result of merging the branch with master. So the configuration is wrong and sets |
25f7ad1
to
d292f2e
Compare
FreeBSD failure is the new OffsetArray issue which is unrelated. There's a conflict though, so you may as well rebase again after that gets fixed. |
d292f2e
to
5040e53
Compare
Rebased again, hopefully this'll be the one! |
No description provided.