RFC/WIP: Conditional 1-D Generators #15023
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the currently open PR #14848.
This adds the ability, in the 1-D case, to support conditional generators, otherwise known as "guards".
Ref #550.
Example
This doesn't yet support the necessary syntax parsing of the form:
The
collect
implementation is probably too naive (not sure if we could get away with not having to evaluate every element), but I'm also not up to speed on the machinerymap
uses for determining the result element type.This PR is more just to show a proof of concept and invite discussion of any other issues we'd need to consider with adding this feature.