float conversion fails on certain substrings

[mrtzh]

Converting SubString to Float64 using float fails on some valid inputs:

julia> float(split("0,1\n",",")[2])
ERROR: ArgumentError("float64(String): invalid number format")
 in float64 at string.jl:1594
 in float at string.jl:1607

In contrast to:

julia> float("1\n")
1.0
julia> split("0,1\n",",")[2]
"1\n"

[IainNZ]

Problem seems to be here:

julia/base/string.jl

Lines 1601 to 1602 in 3f4be47

	float64_isvalid(s::SubString, out::Array{Float64,1}) =
	ccall(:jl_substrtod, Int32, (Ptr{UInt8},Csize_t,Cint,Ptr{Float64}), s.string, s.offset, s.endof, out) == 0

this returns false

[vtjnash]

cross-link #9487

[IainNZ]

I believe fixed by #9783

[mrtzh]

BTW, I still have this problem on julia 0.3.7 (Ubuntu).

[pao]

@mrtzh, the fix wasn't backported to the 0.3 branch; I've asked in that bug if it's a good candidate. Thanks!

[pao]

@mrtzh, the fix has been backported to the release-0.3 branch. If you can build Julia, you can test that now and let us know if it's fixed for you; otherwise, barring any problems it should be available in Julia 0.3.9. Thanks!