Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @scriptdir to @script, and look for environments in parent directories #53352

Closed
tecosaur opened this issue Feb 15, 2024 · 0 comments · Fixed by #53356
Closed

Rename @scriptdir to @script, and look for environments in parent directories #53352

tecosaur opened this issue Feb 15, 2024 · 0 comments · Fixed by #53356
Milestone
1.11

Comments

@tecosaur
Copy link
Contributor

In today's triage call, Stefan's comment about @scriptdir #51149 (comment) (introduced in #50864) was discussed a bit further, and triage seemed broadly approving of the idea that:

  • @scriptdir be renamed to @script
  • @script behaves like @., in that it automatically searches up parent directories for the first environment found

These changes (specifically the first one) will need to be made before 1.11 to be non-breaking.
@tecosaur tecosaur added this to the 1.11 milestone Feb 15, 2024
@oxinabox oxinabox mentioned this issue Feb 16, 2024
Merged
KristofferC pushed a commit that referenced this issue May 28, 2024
@oxinabox
Rename at-scriptdir project argument to at-script and search upwards …
a60f22e 
…for Project.toml (#53356)

Closes #53352

I also noticed it wasn't mentioned in the NEWs.md
and so I added it .

Reconciling the relative path behavior, with the search upwads behavour
requested in #53352 is a thing.
DilumAluthge pushed a commit that referenced this issue Jun 3, 2024
@oxinabox @DilumAluthge
Rename at-scriptdir project argument to at-script and search upwards …
5ad3435 
…for Project.toml (#53356)

Closes #53352

I also noticed it wasn't mentioned in the NEWs.md
and so I added it .

Reconciling the relative path behavior, with the search upwads behavour
requested in #53352 is a thing.
KristofferC pushed a commit that referenced this issue Jun 7, 2024
@oxinabox
Rename at-scriptdir project argument to at-script and search upwards …
ddd5c28 
…for Project.toml (#53356)

Closes #53352

I also noticed it wasn't mentioned in the NEWs.md
and so I added it .

Reconciling the relative path behavior, with the search upwads behavour
requested in #53352 is a thing.

(cherry picked from commit a60f22e)
lazarusA pushed a commit to lazarusA/julia that referenced this issue Jul 12, 2024
@oxinabox @lazarusA
Rename at-scriptdir project argument to at-script and search upwards …
fa8bd99 
…for Project.toml (JuliaLang#53356)

Closes JuliaLang#53352

I also noticed it wasn't mentioned in the NEWs.md
and so I added it .

Reconciling the relative path behavior, with the search upwads behavour
requested in JuliaLang#53352 is a thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

Rename at-scriptdir project argument to at-script and search upwards for Project.toml oxinabox/julia
1 participant
@tecosaur