-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md is unclear about standard library #53200
Comments
Based on your experience, do you have a set of instructions that you can provide in a PR to CONTRIBUTING.md? |
This comment was marked as outdated.
This comment was marked as outdated.
Sounds like we should try to clarify here the list of stdlibs that can be upgraded that way (e.g. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hid a side-conversation about LinearAlgebra having a separate repo, since the resolution was that we deleted it now, and it detracts from the main conversation here about docs |
I just submitted a PR to change something in
LinearAlgebra
(#53186). To do that I followed the instructions here about how to contribute to the standard library, which didn't work. @jishnub then kindly remarked that I should instead follow the instructions for contributing to the core functionality or base libraries, which did work.Either the instructions are incorrect or
LinearAlgebra
is not part of the standard library, despite being in thestdlib
folder. Either way I think the documentation should be updated.The text was updated successfully, but these errors were encountered: