Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_extension_callbacks introduced a data race regression in loading #48498

Closed
vtjnash opened this issue Feb 2, 2023 · 1 comment
Closed
Labels
multithreading Base.Threads and related functionality regression Regression in behavior compared to a previous version
Milestone

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 2, 2023

Most of the work done by run_extension_callbacks is required to be done while holding require_lock (except the call to require, which should be _require_prelocked instead). Instead, it drops the lock just before doing all of this work. This introduces a thread-safety regression.

@KristofferC
Copy link
Member

#48513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality regression Regression in behavior compared to a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants