Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test package should not use printstyled(_...; color=:white), this leads to white on white text in console light theme #42858

Closed
o314 opened this issue Oct 30, 2021 · 1 comment · Fixed by #42864
Closed

Test package should not use printstyled(_...; color=:white), this leads to white on white text in console light theme #42858

o314 opened this issue Oct 30, 2021 · 1 comment · Fixed by #42864

Comments

@o314
Copy link
Contributor

o314 commented Oct 30, 2021 •
edited
Loading

Not everyone use console dark theme !
then all of these prints are turned into white on white.

a very easy to fix thing, mainly a distribution issue.

SEE ALSO
@o314
Copy link
Contributor Author

o314 commented Oct 30, 2021 •
edited
Loading

just done in Pkg, JuliaLang/Pkg.jl@7fe84c1 but not released already (released @ ~ v1.6.2 | v1.6.3)

# https://github.com/JuliaLang/Pkg.jl/blob/master/src/Operations.jl#L1720
print_single(io::IO, pkg::PackageSpec) = print(io, stat_rep(pkg))
# https://github.com/JuliaLang/Pkg.jl/blob/v1.6.1/src/Operations.jl#L1743
print_single(ctx::Context, pkg::PackageSpec) = printstyled(ctx.io, stat_rep(pkg); color=:white)

@KristofferC KristofferC mentioned this issue Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test.jl: no longer explicitly print some things in white JuliaLang/julia
1 participant
@o314