make radical operators juxtaposable #40173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Mar 24, 2021
|
Just need to remove the explicit test for this not working, then LGTM :) |
|
Thank you. Fixed. |
|
Oh, I guess this could use a NEWS item. |
|
Ready? Ready? |
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* make radical operators juxtaposable * fix test * update NEWS.md [skip ci] Co-authored-by: Jameson Nash <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* make radical operators juxtaposable * fix test * update NEWS.md [skip ci] Co-authored-by: Jameson Nash <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* make radical operators juxtaposable * fix test * update NEWS.md [skip ci] Co-authored-by: Jameson Nash <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows juxtaposition with radical operators such as
2√3,x√x,4∛-3, and so on. I believe radical operators are never used as an infix binary operator so it will be safe to allow this syntax unlike other prefix unary operators (e.g.,+,-, etc.).Closes #40094.