Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sincospi #35799

Closed
simeonschaub opened this issue May 8, 2020 · 1 comment · Fixed by #35816
Closed

add sincospi #35799

simeonschaub opened this issue May 8, 2020 · 1 comment · Fixed by #35816

Comments

@simeonschaub
Copy link
Member

Looking at #35792, I think it would make sense to also have a function sincospi, which could have a specialized implementation over just (sinpi(x), cospi(x)). It does look like there is some better performance to be gained.
@StefanKarpinski
Copy link
Member

The range reduction is pretty complicated and costly, so that does make sense 👍

@simeonschaub simeonschaub mentioned this issue May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add sincospi simeonschaub/julia
2 participants
@StefanKarpinski @simeonschaub