Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore type info in show of float types? #33115

Closed
JeffBezanson opened this issue Aug 29, 2019 · 5 comments
Closed

restore type info in show of float types? #33115

JeffBezanson opened this issue Aug 29, 2019 · 5 comments
Assignees
@quinnj
Labels
display and printing Aesthetics and correctness of printed representations of objects.

Comments

@JeffBezanson
Copy link
Member

See #32799 (comment).

Before:

julia> Any[1.0f0, 1.0]
2-element Array{Any,1}:
 1.0f0
 1.0

after:

julia> Any[1.0f0, 1.0]
2-element Array{Any,1}:
 1.0
 1.0
@JeffBezanson JeffBezanson added display and printing Aesthetics and correctness of printed representations of objects. triage This should be discussed on a triage call labels Aug 29, 2019
@JeffBezanson
Copy link
Member Author

Triage concludes we should put back the behavior of show.

But, the difference between 1.0, 1.0f0, and Float16(1.0) is certainly ugly and could use future improvement. Separate issue however.

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Aug 29, 2019
@StefanKarpinski
Copy link
Member

Specifically, it would be great to have a generalizable syntax for this in Julia 2.0 but it will likely be breaking because of numeric literal juxtaposition, e.g. 1g0 or 1h0 would be breaking to introduce as new syntax.

@quinnj
Copy link
Member

quinnj commented Aug 29, 2019

Feel free to assign to me

@quinnj
Copy link
Member

quinnj commented Aug 30, 2019

Ok, PR up: #33124

@quinnj
Copy link
Member

quinnj commented Sep 18, 2019

Ok, for the record, the PR that got merged was #33152 (github was really weird w/ the other one).

@quinnj quinnj closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quinnj quinnj

Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKarpinski @JeffBezanson @quinnj