replace BitArray(shape...) constructors/calls with BitArray(uninitialized, shape...) #24785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
changed the title
Sacha0
force-pushed
the
digbitarr
branch
2 times, most recently
from
f00cc51
to
c4d42fa
Compare
|
Rebased and added the |
…(uninitialized, shape...) etc.
…d, shape...) transition.
…Array constructors.
…zed, shape...) equivalents.
|
Rebased again, changed to more conservative If CI approves and absent objections or requests for time, I plan to merge these changes this evening PT or later. Best! |
|
I think this broke some constructors, noticed in JuliaArrays/OffsetArrays.jl#34 v0.6: julia> BitArray(1:2)
2-element BitArray{1}:
true
truemaster: julia> BitArray(uninitialized, 1:2)
ERROR: MethodError: no method matching BitArray(::Uninitialized, ::UnitRange{Int64})
Closest candidates are:
BitArray(::Uninitialized, ::Integer...) at bitarray.jl:57
BitArray(::Uninitialized, ::Tuple{Vararg{Int64,N}}) where N at bitarray.jl:59
BitArray(::Any) at bitarray.jl:556 |
|
Yes, OffsetArrays will require definitions like those added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates uninitialized-
BitArrayconstructors of the formBitArray[{N}](shape...)in favor ofBitArray[{N}](uninitialized, shape...)equivalents. For background, please see #24595. Best!