Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename bits to bitstring? #24263

Closed
StefanKarpinski opened this issue Oct 21, 2017 · 1 comment
Closed

rename bits to bitstring? #24263

StefanKarpinski opened this issue Oct 21, 2017 · 1 comment
Milestone

Comments

@StefanKarpinski
Copy link
Member

Mentioned here, the bits function, as named, should return a vector of Bools, but instead returns a string of '0' and '1' characters that are a convenient representation of the bits of the item in question. Rather than change the functionality to something less convenient, I propose renaming the function to bitstring which indicates that it returns a string representing the bits.

@StefanKarpinski StefanKarpinski added the triage This should be discussed on a triage call label Oct 21, 2017
@JeffBezanson
Copy link
Member

Closed by #24281.

@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Oct 26, 2017
@JeffBezanson JeffBezanson added this to the 1.0 milestone Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants