Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should merge always return a Dict? #22738

Open
garborg opened this issue Jul 10, 2017 · 1 comment
Open

Should merge always return a Dict? #22738

garborg opened this issue Jul 10, 2017 · 1 comment
Labels
collections Data structures holding multiple items, e.g. sets

Comments

@garborg
Copy link
Contributor

garborg commented Jul 10, 2017

Right now it does, e.g. when merging two ObjectIdDicts. I'd have expected something like calling similar on the first container.

Users can always use merge! if they care to pick a container, so I don't have a strong opinion -- just raising it before 1.0 in case anyone does.
@nalimilan
Copy link
Member

We could reuse the same promotion mechanism as for cat (#20815).

@ararslan ararslan added the collections Data structures holding multiple items, e.g. sets label Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
collections Data structures holding multiple items, e.g. sets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nalimilan @garborg @ararslan