add keyword argument support to invoke
#20345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
approved these changes
Jan 31, 2017
| jl_value_t *kws = jl_get_keyword_sorter(func); | ||
| JL_GC_PUSH1(&argtypes); | ||
| if (jl_is_tuple(argtypes)) { | ||
| jl_depwarn("`invoke(f, (types...), ...)` is deprecated, " |
There was a problem hiding this comment.
I assume we don't need this depwarn?
There was a problem hiding this comment.
Unfortunately we do, since I transform the tuple type, so the following call to jl_f_invoke won't see that there was a tuple.
There was a problem hiding this comment.
I mean this could just be an error since we never supported invoke with with a tuple of types and kwargs....
There was a problem hiding this comment.
I think it's gentler to just leave this as a deprecation even though it could only happen if someone left an invoke(f, (t...), args...) call around and then added a keyword to it. Doesn't really hurt and we'll delete this in 1.0 anyway.
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 12, 2017
tkelman
pushed a commit
that referenced
this pull request
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the prettiest thing ever, but will get the job done.
fixes #7045