deprecate string methods of character predicates, e.g. isnumber("")
#20342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Jan 31, 2017
test/unicode/utf8proc.jl
Outdated
| @test isalpha("23435")==false | ||
| @test iscntrl( string(Char(0x0080))) == true | ||
| @test ispunct( "‡؟჻") ==true | ||
| @test all(isspace," \t \n \r ")==true |
There was a problem hiding this comment.
BTW, maybe change == into === or remove them altogether?
nalimilan
reviewed
Jan 31, 2017
base/strings/basic.jl
Outdated
| true | ||
|
|
||
| julia> isxdigit("0x9") | ||
| julia> isxdigit('z') |
There was a problem hiding this comment.
The 0 and x cases where interesting to show that the prefix wasn't considered as a valid hexadecimal digit. Say this in the docstring?
StefanKarpinski
requested changes
Jan 31, 2017
base/deprecated.jl
Outdated
| @@ -1849,4 +1849,10 @@ end) | |||
|
|
|||
| @deprecate FloatRange{T}(start::T, step, len, den) Base.floatrange(T, start, step, len, den) | |||
|
|
|||
| for name in ("alnum", "alpha", "cntrl", "digit", "number", "graph", | |||
| "lower", "print", "punct", "space", "upper", "isxdigit") | |||
There was a problem hiding this comment.
I think you want just "xdigit" for the last one.
JeffBezanson
force-pushed
the
jb/unliftcharpredicates
branch
from
b49914b
to
541b5f8
Compare
JeffBezanson
force-pushed
the
jb/unliftcharpredicates
branch
from
541b5f8
to
38715b8
Compare
kshyatt
added
deprecation
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 13, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14156