Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate broadcast_zpreserving[!] #19720

Merged
merged 2 commits into from
Dec 30, 2016
Merged

Deprecate broadcast_zpreserving[!] #19720

merged 2 commits into from
Dec 30, 2016

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Dec 25, 2016

This pull request deprecates Base.SparseArrays.broadcast_zpreserving[!], please see #19533 for more. Best!

@Sacha0 Sacha0 added sparse Sparse arrays broadcast Applying a function over a collection labels Dec 25, 2016
@Sacha0 Sacha0 added this to the 0.6.0 milestone Dec 25, 2016
tkelman
tkelman reviewed Dec 25, 2016
View reviewed changes
base/sparse/sparsematrix.jl
@@ -2281,6 +2170,10 @@ floor{To}(::Type{To}, A::SparseMatrixCSC) = floor.(To, A)
trunc{To}(::Type{To}, A::SparseMatrixCSC) = trunc.(To, A)
round{To}(::Type{To}, A::SparseMatrixCSC) = round.(To, A)

# broadcast_zpreserving[!] deprecated in 0.6. Wasn't exported prior, so need these
# definitions for the deprecation to serve its purpose. Remove after 0.6.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also eval the deprecation into this module from deprecated.jl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner. Done. Thanks!

@Sacha0
Deprecate Base.SparseArrays.broadcast_zpreserving[!].
4d83e1c 
Generic sparse broadcast[!] now provides most of Base.SparseArrays.broadcast_zpreserving[!]'s functionality.
@stevengj
Copy link
Member

My inclination is just to do a straight @deprecate _broadcast_zpreserving(f, args...) broadcast(f, args...) here. I can't find a single package actually using this function; if someone needs it, and for some reason broadcast doesn't do what they want, they can file an issue.

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 27, 2016 •
edited
Loading

My inclination is just to do a straight @deprecate _broadcast_zpreserving(f, args...) broadcast(f, args...) here.

Being gentle with the deprecation costs us nothing at this point, the work already being done, so might as well keep the softer deprecation? Thanks!

@stevengj
Copy link
Member

Sure

@Sacha0
Copy link
Member Author

Sacha0 commented Dec 28, 2016

Absent objections or requests for time, I plan to merge this PR Thursday morning PDT. Best!

@tkelman tkelman merged commit 6ad62c4 into JuliaLang:master Dec 30, 2016
@Sacha0 Sacha0 deleted the depbczpres branch December 30, 2016 19:03
@Sacha0
Copy link
Member Author

Sacha0 commented Dec 30, 2016

Thanks for reviewing / resolving conflicts and merging!

@Sacha0 Sacha0 mentioned this pull request Feb 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

Assignees
No one assigned
Labels
broadcast Applying a function over a collection sparse Sparse arrays
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Sacha0 @stevengj @tkelman