Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sub behaviour to match getindex, possibly rename. #16846

Closed
simonbyrne opened this issue Jun 9, 2016 · 2 comments · Fixed by #16972
Closed

Change sub behaviour to match getindex, possibly rename. #16846

simonbyrne opened this issue Jun 9, 2016 · 2 comments · Fixed by #16972
Assignees
@simonbyrne
Milestone
0.5.0

Comments

@simonbyrne
Copy link
Contributor

Following #13612, we should change sub behaviour to match which, as I understand it, basically means renaming slice to sub (and deprecating slice).

There was some discussion in JuliaLang/LinearAlgebra.jl#255 of changing the name to view (which would conflict with ArrayViews), but if so we should make that decision soon.

cc: @andreasnoack @timholy @mbauman
@StefanKarpinski StefanKarpinski mentioned this issue Jun 16, 2016
Closed
27 tasks
@kmsquire
Copy link
Member

kmsquire commented Jun 9, 2016

👍 to changing to view. I think it's clearer about what's happening semantically.

@StefanKarpinski
Copy link
Member

+1 to both

@StefanKarpinski StefanKarpinski added this to the 0.5.0 milestone Jun 16, 2016
@simonbyrne simonbyrne mentioned this issue Jun 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbyrne simonbyrne

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

rename sub/slice -> view JuliaLang/julia
3 participants
@StefanKarpinski @kmsquire @simonbyrne