fix #13021, regression in error message for Mod.x = val

(cherry picked from commit 8f08a1f)
JuliaLang · Sep 11, 2015 · b121d8a · b121d8a
1 parent cf2002a
commit b121d8a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/builtins.c b/src/builtins.c
@@ -744,6 +744,8 @@ JL_CALLABLE(jl_f_field_type)
 {
     JL_NARGS(fieldtype, 2, 2);
     jl_datatype_t *st = (jl_datatype_t*)args[0];
+    if (st == jl_module_type)
+        jl_error("cannot assign variables in other modules");
     if (!jl_is_datatype(st))
         jl_type_error("fieldtype", (jl_value_t*)jl_datatype_type, (jl_value_t*)st);
     int field_index;

diff --git a/test/misc.jl b/test/misc.jl
@@ -170,3 +170,13 @@ end
 let v = sprint(whos, _test_whos_)
     @test contains(v, "x      8 bytes  Float64 : 1.0")
 end
+
+# issue #13021
+let ex = try
+    Main.x13021 = 0
+    nothing
+catch ex
+    ex
+end
+    @test isa(ex, ErrorException) && ex.msg == "cannot assign variables in other modules"
+end