Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Match Octave/Numpy's minimum RWORK size for gesdd. Fixes #4016
gesdd's RWORK size was recently changed to match the netlib header. However, the minimum size calculated results in a segfault. Both Octave and Numpy use a different minimum size, and testing verified that anything smaller than this leads to a segfault. Numpy: https://github.com/numpy/numpy/blob/master/numpy/linalg/umath_linalg.c.src#L2922 Octave: http://hg.savannah.gnu.org/hgweb/octave/file/2f1729cae08f/liboctave/numeric/CmplxSVD.cc#l184
- Loading branch information
9f60588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBezanson
9f60588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmsquire Thanks for tracking this down. I just committed patches to dlasd4 and slasd4 as well as part of #2430 - but you have rebuild openblas if you want these fixes. Hopefully with all of this will make our SVD bugfree.
9f60588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the Numpy and octave wrappers, I feel that our wrappers are considerably simpler and easier to hack.
9f60588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Looking at 484a9f0, matching Numpy and Octave was kind of irrelevant, because we used to have exactly what they have. Either way, the
7*minnm
needs to be there.9f60588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViralBShah, hopefully so! I think you meant #2340. Cheers!