From 78d5bfeef6b4a4d8b6b08cb5ac38bac74dd5d763 Mon Sep 17 00:00:00 2001 From: t-bltg Date: Mon, 21 Aug 2023 18:12:31 +0200 Subject: [PATCH] deps/libsuitesparse: fix empty var in manifest (#50997) `UNINSTALL_libsuitesparse` is an empty variable (used in https://github.com/JuliaLang/julia/blob/74ce6cf070a2a04e836c3e5a2211228a3ac978ef/deps/libsuitesparse.mk#L66): this leads to an empty `usr/manifest/libsuitesparse` file. Maybe `Makefile`s should check for empty manifests and error properly, making the build system more robust ? --- deps/libsuitesparse.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/libsuitesparse.mk b/deps/libsuitesparse.mk index 16d4919031ca5..300f48a98ed12 100644 --- a/deps/libsuitesparse.mk +++ b/deps/libsuitesparse.mk @@ -60,7 +60,7 @@ $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-checked: $(BUILDDIR)/SuiteSp done echo 1 > $@ -UNINSTALL_suitesparse := $(LIBSUITESPARSE_VER) manual_suitesparse $(LIBSUITESPARSE_LIBS) +UNINSTALL_libsuitesparse := $(LIBSUITESPARSE_VER) manual_libsuitesparse $(LIBSUITESPARSE_LIBS) $(build_prefix)/manifest/libsuitesparse: $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled | $(build_prefix)/manifest $(build_shlibdir) echo $(UNINSTALL_libsuitesparse) > $@