Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Julia 1.11-rc1 and 1.11-rc2 #951

Closed
PatrickHaecker opened this issue Jul 15, 2024 · 6 comments · Fixed by #954
Closed

Incompatibility with Julia 1.11-rc1 and 1.11-rc2 #951

PatrickHaecker opened this issue Jul 15, 2024 · 6 comments · Fixed by #954
Labels

Comments

@PatrickHaecker
Copy link
Contributor

PatrickHaecker commented Jul 15, 2024

Creating an app using Julia 1.11-rc1 (also the manifest files pointing to 1.11-rc1) fails with the error

error: too few arguments to function ‘jl_get_binding_wr’
  109 |     jl_binding_t *bp = jl_get_binding_wr(jl_base_module, var);

Replacing line 108 of embedding_wrapper.c by

#if JULIA_VERSION_MAJOR == 1 && JULIA_VERSION_MINOR >= 11
    jl_binding_t *bp = jl_get_binding_wr(jl_base_module, var, 1);
    jl_checked_assignment(bp, jl_base_module, var, firstarg);
#elif JULIA_VERSION_MAJOR == 1 && JULIA_VERSION_MINOR >= 10

lets the build finish successfully. This is a trivial combination of the existing code for 1.9 and 1.10.

@JanisErdmanis
Copy link

I stumbled on the same issue on Julia 1.11-rc1 with MacOS M1.

@PatrickHaecker
Copy link
Contributor Author

I hope that we get an update with this simple fix, soon.

But until we get it, you can copy ~/.julia/packages/PackageCompiler/nT5sD/src/embedding_wrapper.c into your project, modify it accordingly and include the keyword argument c_driver_program = "path_to_modified_embedding_wrapper.c" into your create_app() call.
Obviously, you need to revert that change after the fix is applied.

@KristofferC
Copy link
Member

I hope that we get an update with this simple fix, soon.

You could try make a PR with the fix. Might expedite things.

@PatrickHaecker
Copy link
Contributor Author

Fair enough :-). I need to go through some process because Enterprise, but if it works out I'll make a PR.

@ufechner7
Copy link
Contributor

Same problem with Julia 1.11-rc2

@ufechner7
Copy link
Contributor

ufechner7 commented Jul 30, 2024

#954 fixes the issue for Linux and Windows, but the tests for macOS still fail. Could someone with access to a Mac have a look at the error messages?

@PatrickHaecker PatrickHaecker changed the title Incompatibility with Julia 1.11-rc1 Incompatibility with Julia 1.11-rc1 and 1.11-rc2 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants