-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLAS/LAPACK code assumes all StridedMatrices are column-major #97
Comments
I don't have problems with this. Looks like it is going to be a lot of work though. |
I agree that it is a lot of work. Until it is done, however, it will be dangerous to define any new For 0.3, I see several options:
|
A stopgap: inserting this to each function that wraps BLAS: stride(A, 1) == 1 || error( ... ) |
The array view types in ArrayViews.jl, which are subtypes of |
I'm in favour of undocumented |
We should probably add cc: @jakebolewski |
Since we recently added |
that only handled vectors, not strided matrices or blas and lapack interfaces, so no |
though strided matrix is a union recently, and I think many of the calls do have chkstride1 now, so it may have been fixed just not by the rowvector work. |
Closing this since it is unlikely to do much about row-major arrays - and a package would be a better place for such things. |
Note that this issue is not about supporting row-major arrays, it is about making sure that we call |
I believe we do |
As I understand it, one of the purposes of the
DenseMatrix
type from JuliaLang/julia#987, as discussed in JuliaLang/julia#6212, is to include things like row-major NumPy arrays. However, it looks like most of the BLAS/LAPACK code assumes, without checking, thatStridedMatrix
arguments are column-major (or subsets of column-major matrices), i.e. they assume thatstride(A,1) == 1
.Probably these routines should have
stride(A,1) != 1 && ...generic fallback...
for now. Ideally, they could docc: @andreasnoack, @lindahua
The text was updated successfully, but these errors were encountered: