Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhead of getfield projection approach #9

Closed
jrevels opened this issue Oct 11, 2017 · 2 comments
Closed

overhead of getfield projection approach #9

jrevels opened this issue Oct 11, 2017 · 2 comments

Comments

@jrevels
Copy link
Collaborator

jrevels commented Oct 11, 2017

For the sake of metadata propagation, Cassette will intercept getfield(x, :f) (before type inference) and convert it into something like Cassette._getfield(x, Val(:f)). Bringing :f into the type domain is necessary to enable the type-stable construction of "shadow structs" that can store metadata alongside normal structs.

According to a comment by @vtjnash in the base getfield overloading issue, there is some concern that such an approach may thwart necessary optimizations (such as optimizing namespace references).

@jrevels jrevels changed the title upstream perf issue: overhead of getfield projection approach overhead of getfield projection approach Oct 11, 2017
@jrevels
Copy link
Collaborator Author

jrevels commented Nov 14, 2017

ref JuliaLang/julia#24362

@jrevels
Copy link
Collaborator Author

jrevels commented Dec 12, 2017

This is basically resolved upstream at this point.

@jrevels jrevels closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant