Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows- or 32bit-specific InexactError #284

Closed
timholy opened this issue Apr 19, 2015 · 15 comments
Closed

Windows- or 32bit-specific InexactError #284

timholy opened this issue Apr 19, 2015 · 15 comments

Comments

@timholy
Copy link
Member

timholy commented Apr 19, 2015

Appveyor builds are failing:
https://ci.appveyor.com/project/timholy/images-jl/build/1.0.83/job/sgy1gmtq36rbsemh
https://ci.appveyor.com/project/timholy/images-jl/build/1.0.80/job/wv5yw4qxj0fvugqw
on the following command:

using FixedPointNumbers
aa = Ufixed12[0.6 0.2;
              1.4 0.8]

Can anyone on Windows test this? I don't understand what the problem could be.

@elsuizo
Copy link

elsuizo commented Apr 20, 2015

In my 32-bits Debian laptop with Julia 0.3.7 works fine Tim

@timholy
Copy link
Member Author

timholy commented Apr 20, 2015

Thanks for the useful data point!

@timholy
Copy link
Member Author

timholy commented Apr 20, 2015

Ah, but it will probably only fail on 0.4---trunc didn't throw errors on 0.3.

@tkelman
Copy link
Collaborator

tkelman commented Apr 27, 2015

Ufixed12[0.6 0.2; 1.4 0.8] in isolation doesn't error for me on win32, 0.4, but it does give different answers every time I run it.

Pkg.test("Images") fails for me on win32, 0.4, with the same error you're seeing on appveyor.

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

That's alarming. Sounds like some kind of memory error?

I'm going to file this at FixedPointNumbers and CC some folks who know more. Just to double-check, this works for you on Linux, right? (You have Linux available, right?)

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

Sorry to pester you more, but can you also test things like:

Ufixed12(0.2)
Ufixed12(1.4)
Ufixed12([0.2,1.4])

and let me know what happens?

@tkelman
Copy link
Collaborator

tkelman commented Apr 27, 2015

Just to double-check, this works for you on Linux, right? (You have Linux available, right?)

Yes and yes.

Ufixed(0.2)
Ufixed(1.4)
Ufixed([0.2,1.4])

MethodError: rawtype` has no method matching rawtype(::Type{FixedPointNumbers.Ufixed})``

With Ufixed12(0.2) things appear to work. Worth noting that for the array Ufixed12[0.6 0.2; 1.4 0.8] it looks like the first row is always zeros, the second row has different values every time.

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

Sorry for initially omitting the 12, and thanks for catching it.

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

I think I'm going to file this in julia proper, since I don't think this can be limited to FixedPointNumbers.

@tkelman
Copy link
Collaborator

tkelman commented Apr 27, 2015

Some more info: it's a 32 bit issue, but with different symptoms between Linux vs Windows:

  | | |_| | | | (_| |  |  Version 0.4.0-dev+4524 (2015-04-27 00:18 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 982c60a* (0 days old master)
|__/                   |  i686-linux-gnu

julia> using FixedPointNumbers

julia> Ufixed12[0.6 0.2; 1.4 0.8]
ERROR: InexactError()
 in trunc at float.jl:341
 in hvcat_fill at abstractarray.jl:824
 in typed_hvcat at abstractarray.jl:843

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

That makes more sense than it being OS-specific!

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

Ah, above I see that it might have worked on 0.3.7. You don't happen to have a 32bit (either Windows or Linux) to test on with 0.3, do you?

@tkelman
Copy link
Collaborator

tkelman commented Apr 27, 2015

Looks like the bug is not present on 0.3.8-pre on win32.

@timholy
Copy link
Member Author

timholy commented Apr 27, 2015

Thanks, that's useful to confirm.

@johnnychen94
Copy link
Member

Since this issue is five years old and the current CI passes, I'm closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants