Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice for transition #16

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Advice for transition #16

merged 4 commits into from
Oct 22, 2021

Conversation

mschauer
Copy link
Contributor

@jpfairbanks What you told me...

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #16 (14f12e2) into master (d2d6d29) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files         106      106           
  Lines        5552     5554    +2     
=======================================
+ Hits         5522     5524    +2     
  Misses         30       30           

@ViralBShah ViralBShah mentioned this pull request Oct 20, 2021
@mschauer
Copy link
Contributor Author

The point of contention is

Following SEMVER we suggest a patch release when no graph related functionality is made available through the API, otherwise a major release.

Do we agree with that?

Copy link
Member

@jpfairbanks jpfairbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See the online comments about how to make this clearer.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@simonschoelly
Copy link
Member

The point of contention is

Following SEMVER we suggest a patch release when no graph related functionality is made available through the API, otherwise a major release.

Do we agree with that?

Maybe we need to clarify that more:
version < 1.0 patch/minor release
version >= 1.0 patch/major release

Copy link
Member

@simonschoelly simonschoelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this whole section about the project status way further down in this readme? Maybe keep one sentence at the top.
This makes it easier for new users to figure out what this package can do for them, instead of scaring them away.

@mschauer
Copy link
Contributor Author

Yes, that is already queued #17

README.md Outdated Show resolved Hide resolved
@jpfairbanks jpfairbanks merged commit 6ab2160 into JuliaGraphs:master Oct 22, 2021
@mschauer mschauer deleted the patch-1 branch October 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants