Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of API implementation to the docs #307

Open
gdalle opened this issue Sep 21, 2023 · 6 comments
Open

Add example of API implementation to the docs #307

gdalle opened this issue Sep 21, 2023 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@gdalle
Copy link
Member

gdalle commented Sep 21, 2023

Maybe even an interface check with RequiredInterfaces.jl? I think we can make it nonbreaking

@gdalle gdalle added the documentation Improvements or additions to documentation label Sep 21, 2023
@gdalle
Copy link
Member Author

gdalle commented Sep 21, 2023

@gdalle gdalle mentioned this issue Sep 21, 2023
3 tasks
@tpoisot
Copy link

tpoisot commented Sep 21, 2023

👋🏻 - I can open an issue documenting my attempts to implement the interface, if that helps.

@gdalle
Copy link
Member Author

gdalle commented Sep 21, 2023

That would be very useful! No need for a separate issue though, you can just tell us what went wrong in this one?

@tpoisot
Copy link

tpoisot commented Sep 21, 2023

@gdalle I meant a separate issue / pr on my own repo so I can track my progress!

I'll dig up my notes, but I think the issue was something with type parameters causing problems with some of the methods. It's been a while and I didn't spend more than an half an hour, so as soon as I have a chance to look up what happened, I'll report back with more.

@tpoisot
Copy link

tpoisot commented Sep 21, 2023

One thing that would really help is a little test suite? Something like, "if your implementation is correct, you should be able to run x/y/z". So far, I'm able to map most of the interface to my own functions, but I'd feel a whole lot safer if I had a series of recommended tests I could run.

@gdalle
Copy link
Member Author

gdalle commented Sep 21, 2023

Yeah I agree, and RequiredInterfaces.jl would be a first step in that direction. I think I can manage that before the next release. For a more extensive test suite, I think @simonschoelly's work on GenericGraph could be adapted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants