Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is flipxy=true the default? #68

Closed
Keno opened this issue Mar 14, 2014 · 8 comments
Closed

Why is flipxy=true the default? #68

Keno opened this issue Mar 14, 2014 · 8 comments

Comments

@Keno
Copy link
Contributor

Keno commented Mar 14, 2014

In CairoImageSurface, we have a default of flipxy=true. That seems really confusing. Does anybody know the reason?

@JeffBezanson
Copy link
Contributor

Essentially because Cairo uses C order and we use Fortran order.

@Keno
Copy link
Contributor Author

Keno commented Mar 14, 2014

If I pass in a Julia array indexed by (x,y), it only ends up on the correct axis if flipxy=false.

@JeffBezanson
Copy link
Contributor

That's true, but in that case you're already imagining the array transposed; flipxy=true turns a column of matrix into a column of image.

@Keno
Copy link
Contributor Author

Keno commented Mar 14, 2014

Fair enough.

@Keno Keno closed this as completed Mar 14, 2014
@timholy
Copy link
Member

timholy commented Mar 14, 2014

That said, I tend to do the same as you: when I'm doing graphics, I index by [x,y]. Consequently I would not be opposed to changing this default.

@JeffBezanson
Copy link
Contributor

Ok with me if you want to change it. After all I think you wrote that originally if I recall, Tim.

@timholy
Copy link
Member

timholy commented Mar 15, 2014

I think it was @nolta. I'm a johnny-come-lately when it comes to graphics.

@timholy
Copy link
Member

timholy commented Mar 15, 2014

(I may have refactored, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants