-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blink: output doesn't update with more than one observable #344
Comments
I added some debugging output on the Julia side of WebIO and tracked this down to something going wrong on the I noticed that Blink's And now it's called on the Window (WebIOBlinkComm defined here) So I made the obvious change, and it works:
I have no idea what the difference is between those two, or the exact cause of the problem, but it fixes my cases, and seems reasonable. Will PR to Blink if everyone/anyone's happy? (besides me, I'm already happy 😄) |
Just checked and it also fixes JuliaGizmos/WebIO.jl#357 for me. It'd be good to have a test for this in WebIO, |
I'm still experiencing this. Observables holding an image update in atom or served with mux, but don't update with a Blink.jl electron window. Any ideas? |
Ahh bummer. @rafaqz does I figured this had probably been fixed in @travigd's recent-ish comms overhaul so didn't follow this up. (Aside: commanding work in this org btw @travigd ❤️) Anyway, @travigd was there a reason to change the Blink isopen call from
to
when the webio integration got moved to Blink.jl? If not I can PR to Blink from add my branch there. |
I don't think so, though I'm curious why Feel free to make the PR. :^)
Thanks! I just wish I had more time to dedicate - clearly there are still quite a few issues around the Gizmos ecosystem, but $DAYJOB is eating up all of my time. |
@JobJob Would be great to get your changes into master for Blink.jl. |
Thanks for checking @rafaqz
😄 Know the feeling very well |
Managed to whittle this down to a very simple repro. At the REPL:
When the slider is moved the
observe(s)
outputs don't update. The value ofs[]
is in sync with the slider though in Julia.The same example in Jupyter Notebook (without the last two lines) works fine, it also works with Mux.
This isn't just happening in this contrived example. The actual code that I ran into this with has a PlotlyJS plot between the slider and some output.
JuliaGizmos/WebIO.jl#357 might also be related to this.
How do you even see what messages get sent to the Blink Window in order to debug this? Does this update happen on the js side, or is it slider->julia->window? What code should I look at to get started trying to fix this? It's been a while...
This is with Julia 1.1.0
The text was updated successfully, but these errors were encountered: