Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving numerical stability #4

Closed
sethaxen opened this issue Jan 9, 2023 · 1 comment · Fixed by #14
Closed

Improving numerical stability #4

sethaxen opened this issue Jan 9, 2023 · 1 comment · Fixed by #14

Comments

@sethaxen
Copy link
Collaborator

sethaxen commented Jan 9, 2023

JuliaGeometry/Quaternions.jl#122 updated abs, abs_imag, inv, and / in Quaternions to prevent under/overflow. The approach and tests could be straightforwardly adapted for the corresponding functions here.
@JeffreySarnoff
Copy link
Member

+1 (this is important, imo)

@sethaxen sethaxen mentioned this issue Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make abs, abs_imag, inv, and / resistant to under/overflow JuliaGeometry/Octonions.jl
2 participants
@JeffreySarnoff @sethaxen