Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

vertices(::Simplex) should return <:AbstractVector, not Tuple #127

Open
goretkin opened this issue Dec 5, 2017 · 2 comments
Open

vertices(::Simplex) should return <:AbstractVector, not Tuple #127

goretkin opened this issue Dec 5, 2017 · 2 comments

Comments

@goretkin
Copy link
Contributor

goretkin commented Dec 5, 2017

vertices(s::Simplex) = Tuple(s)

I think the rest of the vertices methods return Array{T,1}.

@SimonDanisch
Copy link
Member

Fair enough.. Care to make a PR? :)

@CarpeNecopinum
Copy link
Contributor

CarpeNecopinum commented Oct 18, 2019

Think it would be nicer to return an SVector here, since the size of the Simplex is known statically.

It's a bit trickier since we can't yet construct a Simplex from an SVector as we can from a Tuple, but I'm on it. (Down from 30 errors in the tests to 11 already :) )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants