-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractMesh
is just AbstractVector
#54
Comments
Or, if determining a meaningful element type restriction is hard, what about doing: abstract type AbstractMesh{Element} <: AbstractVector{Element} end which would fix the root issue without limiting the possible element types. |
I am working on a similar thing for Shapefile.jl JuliaGeo/Shapefile.jl#39 |
Oh, I thought I'm restricting the Element type... That's definitely bad :D Also, 99% of the methods should like use |
I'm working on porting MeshCat.jl from GeometryTypes to GeometryBasics, and I just ran into an interesting method ambiguity that turned out to be due to the fact that
AbstractMesh
is exactlyAbstractVector
:This makes it impossible to write a function that dispatches on a general
AbstractVector
vs. anAbstractMesh
. It also means that any function written for anAbstractMesh
is actually claiming to support any kind of vector of any element, which seems wrong.It's not a blocker for my work, but I think it's likely to be a minor source of annoyance going forward. Would it be possible to put some kind of type restriction on the element of
AbstractMesh
? Anything more restrictive thanAny
would fix the issue and makeAbstractMesh
a usable type.The text was updated successfully, but these errors were encountered: