Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting ColVecs, RowVecs and vec_of_vecs #163

Closed
sharanry opened this issue Sep 7, 2020 · 7 comments
Closed

Exporting ColVecs, RowVecs and vec_of_vecs #163

sharanry opened this issue Sep 7, 2020 · 7 comments
Labels
good first issue Good for newcomers

Comments

@sharanry
Copy link
Contributor

sharanry commented Sep 7, 2020

Shouldn't ColVecs, RowVecs and vec_of_vecs be available to the users? If we are to promote the use of these abstractions, I think it is prudent we export them.

@willtebbutt
Copy link
Member

Absolutely. We've also not properly documented their use. A PR that both exports them and makes documentation on the matter visible to users would be great.

@theogf theogf added the good first issue Good for newcomers label Sep 7, 2020
@codeboy5
Copy link

codeboy5 commented Oct 9, 2020

Hey I would like to take up this issue .
Any tips on how should I proceed ?

@theogf
Copy link
Member

theogf commented Oct 10, 2020

Hi @codeboy5 , thanks for contributing!
For solving this issue you should open a PR where you add the export to the forementioned types/methods and write detailed docs about what they are doing/how to use them.

@st--
Copy link
Member

st-- commented Jan 8, 2021

Should also address this comment: #213 (comment)

@st--
Copy link
Member

st-- commented Jan 18, 2021

Should also add a docstring for defaultobs and remove the hard-coded constant from the docs (see https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/pull/232/files#r559398795)

@devmotion
Copy link
Member

devmotion commented Jan 18, 2021

As I wrote in the comment, I disagree. In my opinion there is no need for a docstring since it is an internal detail that is irrelevant for users. It is only relevant that by default columns are observations.

@theogf
Copy link
Member

theogf commented Jul 27, 2021

Solved in #159

@theogf theogf closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants