Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Paravirtualized Graphics for Github Actions CI #309

Open
ViralBShah opened this issue Mar 8, 2024 · 4 comments
Open

Support for Paravirtualized Graphics for Github Actions CI #309

ViralBShah opened this issue Mar 8, 2024 · 4 comments
Labels
upstream Out of our hands

Comments

@ViralBShah
Copy link
Contributor

Since github now has Apple M1 in Github actions and Julia works with it - does it make sense to set up Github Actions CI? I wonder if Metal can be tested through Github Actions. We already do have CI, so not a huge deal, but I thought it was worth asking.

@christiangnrd
Copy link
Contributor

christiangnrd commented Mar 8, 2024

Tried it on my fork and it doesn't seem to be working. https://github.com/christiangnrd/Metal.jl/actions/runs/8197868351/job/22420547887

@maleadt maleadt changed the title Apple M1 CI Use Github Actions CI Mar 8, 2024
@maleadt
Copy link
Member

maleadt commented Mar 8, 2024

Interesting; I guess the Apple Paravirtual device doesn't fully support Metal. Maybe a good first step would be to try and use local virtualization to see if we support that.

@maleadt maleadt added the help wanted Extra attention is needed label Mar 8, 2024
@tgymnich
Copy link
Member

tgymnich commented Mar 8, 2024

Testing with https://github.com/insidegui/VirtualBuddy.

Custom kernels seem to always result in zeros.

a  = mtl(rand(10))
sum(a)
0.0

Using MPS kernels e.g. for matmul works just fine.

@maleadt
Copy link
Member

maleadt commented Mar 8, 2024

julia> MTL.supports_family(dev, MTL.MTLGPUFamilyApple5)
true

julia> MTL.supports_family(dev, MTL.MTLGPUFamilyApple6)
false

julia> MTL.supports_family(dev, MTL.MTLGPUFamilyMetal3)
false

Looks like the emulated device is significantly below what we require, which is MTLGPUFamilyApple7 + MTLGPUFamilyMetal3.

@maleadt maleadt changed the title Use Github Actions CI Support for Paravirtualized Graphics for Github Actions CI Mar 8, 2024
@maleadt maleadt added upstream Out of our hands and removed help wanted Extra attention is needed labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Out of our hands
Projects
None yet
Development

No branches or pull requests

4 participants