Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwcall codegen regression on 1.9-rc1 #399

Closed
maleadt opened this issue Mar 10, 2023 · 1 comment
Closed

kwcall codegen regression on 1.9-rc1 #399

maleadt opened this issue Mar 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@maleadt
Copy link
Member

maleadt commented Mar 10, 2023

See JuliaGPU/CUDA.jl#1787, bisected to:

09757f7c83f91b8428f8229375f77810fa829683 is the first bad commit
commit 09757f7c83f91b8428f8229375f77810fa829683
Author: Shuhei Kadowaki <[email protected]>
Date:   Wed Mar 1 19:07:59 2023 +0900

    effects: taint `nonoverlayed` when bailing out inference (#48838)

@aviatesk Any thoughts on why JuliaLang/julia#48838 broke kwcall in GPU code again? This due to the presence of overlay methods (seeing how we overlay Core.throw_inexacterror), but we can't fix the underlying issue in time for 1.9, so that's why I did JuliaLang/julia#48116 when last looking at this.

Also, what's the reason you backported that PR? It doesn't reference anything it fixes, nor ever had the backport label (or a discussion on whether it should). So maybe the easiest "fix" is to revert that change?

x-ref #384

@maleadt
Copy link
Member Author

maleadt commented Mar 14, 2023

Will be fixed on 1.9-rc2.

@maleadt maleadt closed this as completed Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant