You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
09757f7c83f91b8428f8229375f77810fa829683 is the first bad commit
commit 09757f7c83f91b8428f8229375f77810fa829683
Author: Shuhei Kadowaki <[email protected]>
Date: Wed Mar 1 19:07:59 2023 +0900
effects: taint `nonoverlayed` when bailing out inference (#48838)
@aviatesk Any thoughts on why JuliaLang/julia#48838 broke kwcall in GPU code again? This due to the presence of overlay methods (seeing how we overlay Core.throw_inexacterror), but we can't fix the underlying issue in time for 1.9, so that's why I did JuliaLang/julia#48116 when last looking at this.
Also, what's the reason you backported that PR? It doesn't reference anything it fixes, nor ever had the backport label (or a discussion on whether it should). So maybe the easiest "fix" is to revert that change?
See JuliaGPU/CUDA.jl#1787, bisected to:
@aviatesk Any thoughts on why JuliaLang/julia#48838 broke kwcall in GPU code again? This due to the presence of overlay methods (seeing how we overlay
Core.throw_inexacterror
), but we can't fix the underlying issue in time for 1.9, so that's why I did JuliaLang/julia#48116 when last looking at this.Also, what's the reason you backported that PR? It doesn't reference anything it fixes, nor ever had the backport label (or a discussion on whether it should). So maybe the easiest "fix" is to revert that change?
x-ref #384
The text was updated successfully, but these errors were encountered: