-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing support from AbstractArrays to AnyArrays for tril! and triu! functions in LinAlg + support for printarray and getproperty of QR #458
base: master
Are you sure you want to change the base?
Conversation
d76756d
to
0c26c5f
Compare
Those Until we have something like JuliaLang/julia#48861 for Thoughts, @vchuravy? |
a1d4388
to
fba39d8
Compare
I don't think you've reverted anything. Can you rebase on top of latest master too, when you're at it? |
df4f97b
to
28d252e
Compare
@maleadt : I removed the mul functionality for this pull request. I only need it for tril! and triu! functions for JuliaGPU/CUDA.jl#1764. I added the getproperty and printarray function for QR as well. |
e3fab7c
to
48e465f
Compare
Yeah that's much less invasive and should be fine The CUDA.jl CI failure as part of the CUSOLVER qr tests looks related though? |
The error persist. Did you expect it to disappear (given the CI restarts)? It would also be good to have some tests, for the |
Squashed and rebased. I'm confused how this is supposed to work though. You're adding functionality for Which back-ends are you interested in, specifically? Maybe it's better to focus first on adding the change there (i.e., in CUDA.jl) before making it generic? |
Changing this for triu and tril, adding support for QRQ for getproperty and printarray