Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed/wrap lld linker #27

Closed
jpsamaroo opened this issue Mar 17, 2019 · 2 comments · Fixed by #187
Closed

Embed/wrap lld linker #27

jpsamaroo opened this issue Mar 17, 2019 · 2 comments · Fixed by #187
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jpsamaroo
Copy link
Member

Currently we invoke ld.lld manually to link our kernel's .o file into the final executable. We should figure out how to embed lld (or call the appropriate C++ functions in LLVM) so that we don't rely on the lld binary existing on the user's system.
@vchuravy
Copy link
Member

Julia currently doesn't ship ldd, but luckily HSA only really supports Linux, so we can assume that we have a linker available.

@jpsamaroo jpsamaroo transferred this issue from JuliaGPU/AMDGPUnative.jl Jul 6, 2020
@jpsamaroo jpsamaroo mentioned this issue Jul 14, 2020
Closed
@jpsamaroo
Copy link
Member Author

We should pull in LLVM_full_jll if possible, it seems like that has a working ld.lld.

@jpsamaroo jpsamaroo added enhancement New feature or request good first issue Good for newcomers labels Jul 14, 2020
@jpsamaroo jpsamaroo linked a pull request Feb 15, 2022 that will close this issue
LB Julia to 1.7, upgrade to ROCm 4.2 #187
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LB Julia to 1.7, upgrade to ROCm 4.2 JuliaGPU/AMDGPU.jl
2 participants
@vchuravy @jpsamaroo