Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear wave #67

Merged
merged 30 commits into from
Apr 24, 2024
Merged

Linear wave #67

merged 30 commits into from
Apr 24, 2024

Conversation

benedict-96
Copy link
Collaborator

Added linear wave equation as we have it in https://arxiv.org/abs/2312.10004.

@benedict-96
Renamed toda_lattice_initial_condition.jl to bump_initial_condition.jl
078a865
@benedict-96
alpha^2 -> alpha
ffa7e7d
@benedict-96
This assembles the K matrix as discussed in our symplectic autoencode…
3119161 
…r paper.
@benedict-96
Geometric problem for the linear wave.
0a9a95d
@benedict-96
Added Offset arrays.
a301e31
@benedict-96
Added LaTeXStrings.
e487a3b
@benedict-96
Added thid degree spline that is used to make the initial condition.
d68594c
@benedict-96
Added weakly-symplectic paper.
5f5c6b0
@benedict-96
Short description of the initial condition used for the Toda lattice …
9c9904e 
…and the linear wave equation.
@benedict-96
Docs for the linear wave equation.
e79ae3c
@benedict-96
Changed tstep and tspan (to the same values we had in the paper).
2c2d3d1
@benedict-96
Added third-degree spline.
b52c051
@benedict-96
Changed times at which we plot.
0bb38ed
@benedict-96
Added line describing simulation results.
373b8dd
@benedict-96
Added linear wave.
90a61b3
@benedict-96
Changed value to the same we have in the paper (28 -> 20) and also de…
696a88c 
…fined Omega.
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 32.08%. Comparing base (b05d3b7) to head (a698959).

Files Patch % Lines
src/linear_wave.jl 8.33% 22 Missing ⚠️
src/bump_initial_condition.jl 86.36% 6 Missing ⚠️
src/toda_lattice.jl 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   31.76%   32.08%   +0.32%     
==========================================
  Files          29       30       +1     
  Lines        1961     2010      +49     
==========================================
+ Hits          623      645      +22     
- Misses       1338     1365      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft April 22, 2024 06:49
@benedict-96 benedict-96 marked this pull request as ready for review April 22, 2024 15:24
@benedict-96 benedict-96 marked this pull request as draft April 22, 2024 15:36
@benedict-96
Copy link
Collaborator Author

I will get rid of ForwardDiff dependency and then mark as "ready for review" (again).

@benedict-96
Copy link
Collaborator Author

Removed ForwardDiff dependency (it's still used for testing purposes however) and changed get -> compute.

@benedict-96 benedict-96 marked this pull request as ready for review April 23, 2024 08:24
@benedict-96
get -> compute
1efea4f 
get -> comute. get_tstep -> _tstep.

get -> compute.
@benedict-96 benedict-96 requested a review from michakraus April 23, 2024 14:24
@michakraus michakraus merged commit a9d966d into main Apr 24, 2024
12 checks passed
@michakraus michakraus deleted the linear_wave branch April 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michakraus michakraus michakraus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedict-96 @michakraus