Internally now only working with NamedTuples, not with Tuples when dealing with q and p.
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 64.35% 64.10% -0.25%
==========================================
Files 99 100 +1
Lines 2581 2591 +10
==========================================
Hits 1661 1661
- Misses 920 930 +10 ☔ View full report in Codecov by Sentry. |
michakraus
deleted the
convert_tuple_functions_to_named_tuple_functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... also got rid of an extra routine in
psd_like_layer.jl. We now don't have(::PSDLayer{M, N})(x::AbstractVecOrMat, ps::NamedTuple)and(::PSDLayer{M, N})(x::AbstractVecOrMat, ps::NamedTuple), but only(::PSDLayer{M, N})(x::AbstractArray, ps::NamedTuple).