Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplication and addition tests for custom arrays #98

Merged
merged 65 commits into from
Dec 20, 2023
Merged

Multiplication and addition tests for custom arrays #98

merged 65 commits into from
Dec 20, 2023

Conversation

benedict-96
Copy link
Collaborator

Added tests for addition, scalar multiplication and matrix multiplication of custom arrays. Tried to make tests in runtests.jl more readable.

@benedict-96
Remove old array tests.
ba96b35
@benedict-96
Removed the block matrices. This is now done by the LinearSympNetLayers.
0fb9156
@benedict-96
Hope this fixed the TODO list.
dd4e8a5
@benedict-96
We are not using those arrays anymore.
35c0d48
@benedict-96
Factored out sampling of arrays.
1f1e30d
@benedict-96
Got rid of some some symplectic arrays and included the supertype for…
51c7c76 
… horizontal components as an extra file.
@benedict-96
Updated docs.
3876be5
@benedict-96
New supertype for the horizontal components.
48300b2
@benedict-96
Added new routine for multiplying symmetric matrix from the right ont…
0dfbc63 
…o a matrix.
@benedict-96
Test addition of various custom arrays.
21bb931
@benedict-96
Removed tests for various symplectic arrays that are no longer part o…
969a6cb 
…f GML.
@benedict-96
Added routine for Base.one. This is copied from SkewSymMatrix.
e0b81cf
@benedict-96
Slightly improved readability.
16b28ba
@benedict-96
Added addition tests for the remaining custom arrays.
df07bfb
@benedict-96
Added tests for addition, scalar multiplication and matrix multiplica…
e81ff2e 
…tion for custom arrays.
@benedict-96
Changed order of how files are included. Symmetric now depends on Ske…
a94c57c 
…wSymmetric.
@benedict-96
Fixed typo.
c6a350e
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (0be53b2) 64.10% compared to head (1e659d7) 68.29%.
Report is 59 commits behind head on main.

Files Patch % Lines
src/arrays/symplectic.jl 0.00% 15 Missing ⚠️
src/arrays/symmetric.jl 11.11% 8 Missing ⚠️
src/optimizers/optimizer.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   64.10%   68.29%   +4.18%     
==========================================
  Files         100       96       -4     
  Lines        2591     2438     -153     
==========================================
+ Hits         1661     1665       +4     
+ Misses        930      773     -157

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michakraus
Copy link
Member

Unfortunately, we need a rebase here.

benedict-96 and others added 28 commits December 19, 2023 18:24
@benedict-96
Added a comment saying that the constructor can be called with DataLo…
137d640 
…ader as input.
@benedict-96
Added default for number of epochs.
b57d148
@benedict-96
Combined matrix and tensor routines into one. Added another loss for …
3100b0b 
…autoencoder qp data.
@benedict-96
Commented out a section that is probably not needed.
718174f
@benedict-96
Test data loader for qp data.
370ee05
@benedict-96
Renamed and added tests.
14d6ae2
@benedict-96
Adjusted symplectic matrix.
9edec7b
@benedict-96
dim was missing for specifying default.
2acdd24
@benedict-96
dl has no field data.
f8b8fff
@benedict-96
Fixed typos.
8c4c73b
@benedict-96
Merge branch 'increase_data_loader_test_coverage' of https://github.c…
fc92faa 
…om/JuliaGNI/GeometricMachineLearning.jl into increase_data_loader_test_coverage
@benedict-96
Removed method that appeared twice for some reason.
d072594
@benedict-96
Forgot to commit before.
d071839
CompatHelper: bump compat for GPUArrays to 10, (keep existing compat)
2bb3f29
@michakraus
Merge pull request #102 from JuliaGNI/compathelper/new_version/2023-1…
8696833 
…2-20-00-35-42-820-02318887484

CompatHelper: bump compat for GPUArrays to 10, (keep existing compat)
@michakraus
Merge pull request #101 from JuliaGNI/increase_data_loader_test_coverage
9b56781 
Increase data loader test coverage
@benedict-96
Added new routine for multiplying symmetric matrix from the right ont…
7aff016 
…o a matrix.
@benedict-96
Resolved merge conflict.
3321d4b
@benedict-96
Resolved conflict (removed triangular matrices).
65ee5c0
@benedict-96
Slightly improved readability.
0f958d6
@benedict-96
Resolved conflict.
250c701
@benedict-96
Resolved conflict (accepted both changes).
b320aaf
@benedict-96
Added tests for addition, scalar multiplication and matrix multiplica…
5ae3067 
…tion for custom arrays.
@benedict-96
Resolved merge conflict.
d4bbb6c
@benedict-96
Fixed (apparent) conflict.
f25e3fa
@benedict-96
Fixed typo.
e0cc2d2
@benedict-96
Resolved merge conflicts.
b7bf98b
@benedict-96
Fixed comments from previous merge conflict.
1e659d7
@michakraus michakraus merged commit eb94a21 into main Dec 20, 2023
12 of 15 checks passed
@michakraus michakraus deleted the multiplication_and_addition_tests_for_custom_arrays branch December 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michakraus michakraus Awaiting requested review from michakraus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedict-96 @michakraus