Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment on parameterlength and extended the corresponding function in ANN. #94

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

benedict-96
Copy link
Collaborator

Added parameterlength routine in AbstractNeuralNetworks and included this comment in the sympnet_tutorial file.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c0ddab) 64.35% compared to head (99d41e1) 63.98%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   64.35%   63.98%   -0.38%     
==========================================
  Files          99      100       +1     
  Lines        2581     2596      +15     
==========================================
  Hits         1661     1661              
- Misses        920      935      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michakraus
Copy link
Member

@benedict-96 The docs are failing to build because of a missing parameterlength method. Please check and fix.

@benedict-96
Copy link
Collaborator Author

Oh, of coure. Sorry. I added a method in AbstractNeuralNetworks (branch main) but that of course doesn't trigger a new release. Changed something in the script, the tests should go through now.

@michakraus michakraus merged commit 858d440 into main Dec 12, 2023
13 of 15 checks passed
@michakraus michakraus deleted the add_number_of_network_parameters branch December 12, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants