Implementation of BFGS optimizer #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…various matrix-tensor products is now done with one specific function instead of many different ones.
…kew-symmetric matrix.
…rent from regular transformer script.
…d on anything in GML.
…should serve the same purpose).
…same purpose as a broadcasting operation).
… a neural network as input.
…based on an online comment.
…rays. This now works for some reason.
…lent, but check first!
…id of some CPU computation.
… (and an optional type) as input arguments.
… should still be checked!
…onger exported by default.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 66.23% 64.30% -1.93%
==========================================
Files 96 99 +3
Lines 2535 2583 +48
==========================================
- Hits 1679 1661 -18
- Misses 856 922 +66 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the BFGS optimizer including docs. In the process I also made the
transformer_mnistscript more readable and created an additionalClassificationTransformerneural network. The functions inmulti_head_attention.jl,retractions.jlandglobal_sections.jlhave been simplified significantly.The pr got bigger than I intended (again). Will be more careful in the future.