Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for AbstractNeuralNetworks to 0.5 #179

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 6, 2024

This pull request changes the compat entry for the AbstractNeuralNetworks package from 0.4 to 0.4, 0.5.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@michakraus michakraus force-pushed the compathelper/new_version/2024-12-06-01-00-12-914-00751357659 branch from d273bb9 to f67429a Compare December 6, 2024 01:00
@benedict-96
Copy link
Collaborator

initialparameters need to be adjusted to fit JuliaGNI/AbstractNeuralNetworks.jl@29ebbea.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (cde4d3f) to head (0bd231b).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/data_loader/data_loader.jl 0.00% 6 Missing ⚠️
src/training_method/variational_method.jl 0.00% 6 Missing ⚠️
src/architectures/autoencoder.jl 71.42% 2 Missing ⚠️
src/architectures/lagrangian_neural_network.jl 50.00% 2 Missing ⚠️
src/arrays/stiefel_projection.jl 50.00% 2 Missing ⚠️
...c/kernels/tensor_transpose_tensor_transpose_mul.jl 0.00% 2 Missing ⚠️
src/training/train.jl 0.00% 2 Missing ⚠️
src/architectures/neural_network_integrator.jl 50.00% 1 Missing ⚠️
src/architectures/transformer_integrator.jl 50.00% 1 Missing ⚠️
src/arrays/symmetric.jl 83.33% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   64.38%   64.41%   +0.03%     
==========================================
  Files         119      119              
  Lines        3695     3704       +9     
==========================================
+ Hits         2379     2386       +7     
- Misses       1316     1318       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96 benedict-96 marked this pull request as draft December 16, 2024 18:16
@benedict-96
Copy link
Collaborator

NOTE: this is set to draft until nn.params has been replaced with params(nn) everywhere in the code.

@benedict-96 benedict-96 changed the title CompatHelper: bump compat for AbstractNeuralNetworks to 0.5, (keep existing compat) CompatHelper: bump compat for AbstractNeuralNetworks to 0.5 Dec 17, 2024
@benedict-96 benedict-96 marked this pull request as ready for review December 17, 2024 10:40
@michakraus michakraus merged commit 1774815 into main Dec 17, 2024
10 of 13 checks passed
@michakraus michakraus deleted the compathelper/new_version/2024-12-06-01-00-12-914-00751357659 branch December 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants