Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed if statement. #169

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Removed if statement. #169

merged 1 commit into from
Aug 28, 2024

Conversation

benedict-96
Copy link
Collaborator

Fixes #166.

There was an if statement due to a KernelAbstractions bug that was fixed in JuliaGPU/KernelAbstractions.jl#515.

@benedict-96 benedict-96 requested a review from michakraus August 27, 2024 12:34
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.14%. Comparing base (5536a75) to head (1f3bc3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   68.14%   68.14%           
=======================================
  Files         122      122           
  Lines        3667     3667           
=======================================
  Hits         2499     2499           
  Misses       1168     1168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michakraus michakraus merged commit 20bddd6 into main Aug 28, 2024
13 checks passed
@michakraus michakraus deleted the remove_if_statement branch August 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ifs that originated in a KernelAbstractions Problem
2 participants