Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of OptimizerMethod subtypes. #149

Open
benedict-96 opened this issue May 14, 2024 · 0 comments
Open

Naming of OptimizerMethod subtypes. #149

benedict-96 opened this issue May 14, 2024 · 0 comments
Labels
optimizers Will be solved once we moved everything to `GeometricOptimizers`

Comments

@benedict-96
Copy link
Collaborator

Sub types of OptimizerMethod shouldn't be called AdamOptimizer, MomentumOptimizer etc.
Adam, Momentum (or possibly AdamMethod, MomentumMethod) would be better!
@benedict-96 benedict-96 added the optimizers Will be solved once we moved everything to `GeometricOptimizers` label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimizers Will be solved once we moved everything to `GeometricOptimizers`
Projects
Geometric Machine Learning Development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benedict-96