Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometricIntegrators and EulerLagrange both export HamiltonianSystem #17

Open
benedict-96 opened this issue Oct 29, 2024 · 2 comments
Open

Comments

@benedict-96
Copy link

Perhaps HamiltonianSystem should be defined in https://github.com/JuliaGNI/GeometricIntegratorsBase.jl and then imported by GeometricIntegrators and EulerLagrange so that we don't have the conflict when using both packages?

(issue was raised by @ZeyuanLee)

@ZeyuanLee
Copy link

Get the problem when include using GeometricIntegrators and using EulerLagrange in a problem module. Remove using GeometricIntegrators could work, but both packages do export HamiltonianSystem

@michakraus
Copy link
Member

michakraus commented Dec 5, 2024

Indeed GeometricIntegrators.jl should not export HamiltonianSystem. I will look into this. This definitely should not be defined in GeometricIntegratorsBase.jl.

EDIT:

I cannot see any HamiltonianSystem in GeometricIntegrators.jl. Are you sure this is the cause of whatever error you observed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants